Change Graphql Query authz method to QUERY #72
+26
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjeerddie
force-pushed
the
change-graphql-query-method
branch
from
115fab9 to
812a033
Compare
tjeerddie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
GraphQLOPAAuthorizationuses thePOSTmethod, which is also used by API endpoints for creating resources.This led to an unintended side effect that granting a user access to GraphQL could also grant them access to other POST endpoints, unless those were explicitly restricted. Changing the method to a dedicated one (such as
QUERY) eliminates this overlap and prevents accidental authorization leaks.I think that mutation doesn't necessarily need to be changed since its similar to
POSTrequests.