Add auto_error
parameter and fix authorization bug
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When
is_bypassable_request
decides to bypass a request for any reason, it sendsNone
to theauthorize
function in the Authorization classes. This causes a bug because theauthorize
function expects a user as a dict.I also made the
authenticate
function more explicit about theid_token_extractor
. It used to raise an exception when it couldn't find a token in the header. I removed the line that returnedNone
after this, as it wasn't necessary.The function is already set to raise an exception when it can't find a token, so that code wasn't needed.
Changes Made
auto_error
parameter to theextract
method inIdTokenExtractor
.HttpBearerExtractor
to use theauto_error
parameter.None
to theauthorize
function, causing authorization failures.authenticate
method explicit aboutid_token_extractor
and removed unnecessary lines that returnedNone
.