Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues with the previewers #821

Closed
wants to merge 3 commits into from
Closed

Conversation

theCapypara
Copy link
Contributor

@theCapypara theCapypara commented Nov 18, 2023

This fixes a bunch of related issues related to switching between previewers.

  • Fixes "Show Preview Window" always uses internal previewer #700
  • When switching from a demo using the external previewer to internal previewer in inline mode, the stack is now correctly switched to the "inline" child item
  • The button to open the external previewer demo is now no longer shown when switching between languages until the new language was "Run" once (ie. the previewer and window were created)*
  • The Vala and Python previewer now don't destroy the preview window when closing it, this allows for the "Show Previewer Window" button to re-open the windows

There are probably still a few issues left, we should consider refactoring the previewer logic to not have so many different bits and pieces that could lead to inconsistent states. Maybe add some sort of central controlling interface that makes sure the previewer is always in a consistent state?

*: There is still a minor issue with this: When opening and running another demo using the external previewer, and then clicking the "Show Preview Window" button in the old but still-opened library window, this will instead show the new demo window, since the external previewer always just has one demo loaded. This is probably minor enough to not worry about until a potential re-write.

@theCapypara theCapypara requested a review from lw64 November 18, 2023 16:31
Copy link
Contributor

@lw64 lw64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonnyp
Copy link
Contributor

sonnyp commented Jan 14, 2024

The Vala and Python previewer now don't destroy the preview window when closing it, this allows for the "Show Previewer Window" button to re-open the windows

The button to open the external previewer demo is now no longer shown when switching between languages until the new language was "Run" once (ie. the previewer and window were created)*

Currently closing the window after running Vala/Python/Rust destroys it and when you click "Show Preview Window" it does so with the internal previewer. This is working as intended, see #700

When switching from a demo using the external previewer to internal previewer in inline mode, the stack is now correctly switched to the "inline" child item

I'm not following, can you list steps to reproduce?

@theCapypara
Copy link
Contributor Author

I'm closing this, as this has been obsoleted as far as I understand, but feel free to re-open.

@theCapypara theCapypara closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show Preview Window" always uses internal previewer
3 participants