Fix various issues with the previewers #821
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of related issues related to switching between previewers.
There are probably still a few issues left, we should consider refactoring the previewer logic to not have so many different bits and pieces that could lead to inconsistent states. Maybe add some sort of central controlling interface that makes sure the previewer is always in a consistent state?
*: There is still a minor issue with this: When opening and running another demo using the external previewer, and then clicking the "Show Preview Window" button in the old but still-opened library window, this will instead show the new demo window, since the external previewer always just has one demo loaded. This is probably minor enough to not worry about until a potential re-write.