[둔덩] 3단계 - HTTP 웹 서버 리팩터링 미션 제출합니다. #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 요청별로 구별하는 기능
- Request Parameter 추출하기
- QueryString 추출하기
- QueryString 형식이 아닐 때 예외 처리
- inputData User로 변환하기
- 올바른 형식의 input Data가 아닐 때 예외 처리
- Request Body의 값 추출하기
- responseHeader -> response200Header
- redirect -> redirect302Header
- Request에서 BufferedReader를 안갖고있게 수정
- Request에서 body를 갖고있게 수정
- RequestUtils에서 queryString을 Map으로 변환하도록 수정
- Http Header Enum으로 관리
- 문자열 중복 제거
- request, response enum 분리
- charset=utf-8 상수로 중복 제거
- Predicate 메서드 레퍼런스로 수정
- UserSerivce 단위 테스트
- User 단위 테스트
- TemplateUtils 단위 테스트
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 구구~
너무 오랜만에 리뷰 요청하네요...
많이많이 지적해주시면 천천히 고쳐나가겠습니다!