이미지 리스트 업로드 병렬 처리로 변경 및 롤백 기능 추가 #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Jacoco Test Coverage
|
jjongwa
requested changes
Nov 22, 2023
| @@ -30,9 +34,21 @@ public class ImageUploader { | |||
| private String folder; | |||
|
|
|||
| public List<String> uploadImages(final List<ImageFile> imageFiles) { | |||
| return imageFiles.stream() | |||
| .map(this::uploadImage) | |||
| List<CompletableFuture<String>> imageUploadsFuture = imageFiles.stream() | |||
Comment on lines
43
to
44
| private List<String> getUploadedImageNamesFromFutures(List<CompletableFuture<String>> futures) { | ||
| List<String> fileNames = new ArrayList<>(); |
There was a problem hiding this comment.
후하하하하하하하하하!!!!!!!!!!!!!!!!!!!1 새맥북에게 final의 중요성을 일깨워주고오겠습니다아ㅏㅏ아ㅏ
waterricecake
approved these changes
Nov 28, 2023
LJW25
approved these changes
Nov 28, 2023
hgo641
force-pushed
the
refactor/imagesUpload
branch
from
53952e8 to
dd5b336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More