Experimental Plugins #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added error returning, added example hast and recma plugins, fixed clippy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an experimental plugin implementation as discussed in #5. Unfortunately I'm not very experienced in rust, so I have literally 0 idea if what I came up with is anywhere idiomatic. Maybe there is a way to avoid wrapping the plugin closures in a
std::rc::Rc, and maybe support non static ones, but I'm not sure. Also, the plugins work by cloning the current tree and returning a modified version of it. We probably should instead modify in-place and provide a wrapper for those who prefer to clone and return.