Add a leading slash to ensure the SW gets registered at the site root#1
Open
Trippnology wants to merge 1 commit into
Open
Add a leading slash to ensure the SW gets registered at the site root#1Trippnology wants to merge 1 commit into
Trippnology wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a leading slash, the service worker registration URL is relative to the current page, rather than to the site root. source
This causes a problem when visiting a sub-page such as
example.com/some/pathas the SW tries to register atexample.com/some/service-worker.jsAs service workers should be registered at the site root, hopefully this change should be right for everyone.
Thanks for this module - I was up and running in minutes! :)