[fix/#58]: 과목 편집 문제 해결 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-feature-ranking-api-contect
…-feature-ranking-api-contect
riverkite0708
approved these changes
Aug 22, 2024
| .subject_item_wrapper { | ||
| position: relative; | ||
| display: inline-block; | ||
| max-width: 99%; |
There was a problem hiding this comment.
왜 최대 넓이를 99%만 줬는지 궁금합니다~!
There was a problem hiding this comment.
100%로 하면 (-)삭제 버튼이 살짝 짤리던데 width값을 줄이는 거 말고 다른 방법이 있을까요?!
There was a problem hiding this comment.
overflow-x 때문인데 전에도 overflow-y 때문에 감싸고 있는 박스에 padding-top:5px을 줬었죠~ 마찬가지로 하면 됩니다^_^
그런데 padding-right를 주면 좌우여백이 조금 달라지니 margin-right:-5px로 당겨주면 더더더 좋겠습니다~
There was a problem hiding this comment.
이거 다시 해봤을 때 max-width:100%로 해도 큰 문제가 없는 것 같아서 100%로 수정했습니다,,!
| const isDuplicate = subjects.some((subject) => subject.name === newSubjectName.trim()); | ||
| if (isDuplicate) { | ||
| alert('이 과목은 이미 존재합니다.'); | ||
| return; |
There was a problem hiding this comment.
중복 체크 해주는거 좋은것 같습니다!
Kong-E
reviewed
Aug 23, 2024
api/subjectFormApi.ts
Outdated
| if (requestBody.addedSubjects.length === 0 && requestBody.deletedSubjects.length === 0) { | ||
| return { success: true }; // 변경 사항이 없으므로 성공으로 처리 | ||
| } | ||
|
|
||
| return { success: true }; | ||
| } catch (error) { | ||
| console.error('subjectFormApi 에러:', error); |
There was a problem hiding this comment.
error code에 따라 메시지를 다르게 전달했으면 좋겠어요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 연관된 이슈 번호
🛠 구현 사항
📚 변경 사항
주말 동안 수정한 사항
💬 To Reviewers