isBorrowCollateralized tests#361
Open
MishaShWoof wants to merge 6 commits intofeat/service-patchfrom
Open
Conversation
Collaborator
VladyslavPerederWoof
left a comment
VladyslavPerederWoof
left a comment
There was a problem hiding this comment.
Need tests for:
Case when the user has a couple of collaterals, and liquidity will be enough to cover the borrow position in the middle (e.g., 4 collaterals, liquidity calculation exits on the 3rd collateral)
In a case where the user will take a loan, has 3 collaterals, and only the last one will cover the debt.
Case on proper liquidity calculation with all 24 collaterals. Huge loan, and all 24 collaterals are used for covering debt.
Case when all 24 supplied collaterals will not cover the debt.
Each case is described separately. For the last 2 cases, use a separate describe block 24 collaterals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for isBorrowCollateralized function in Comet