Skip to content

tweak: subscriptions support to ECE methods in settings #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

tweak: subscriptions support to ECE methods in settings #4781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion client/components/recurring-payment-icon/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ const RecurringPaymentIcon = () => {
'woocommerce-gateway-stripe'
) }
>
<Icon src={ icon } alt="" />
<Icon
src={ icon }
alt={ __(
'Supports recurring payments',
'woocommerce-gateway-stripe'
) }
/>
</StyledTooltip>
);
};
Expand Down
34 changes: 22 additions & 12 deletions client/settings/payment-request-section/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
PAYMENT_METHOD_LINK,
PAYMENT_METHOD_AMAZON_PAY,
} from 'wcstripe/stripe-utils/constants';
import RecurringPaymentIcon from 'wcstripe/components/recurring-payment-icon';

const PaymentRequestSection = () => {
const [ isPaymentRequestEnabled, updateIsPaymentRequestEnabled ] =
Expand Down Expand Up @@ -115,10 +116,13 @@ const PaymentRequestSection = () => {
</div>
<div className="express-checkout__label-container">
<div className="express-checkout__label">
{ __(
'Apple Pay / Google Pay',
'woocommerce-gateway-stripe'
) }
<span>
{ __(
'Apple Pay / Google Pay',
'woocommerce-gateway-stripe'
) }
</span>
<RecurringPaymentIcon />
</div>
<div className="express-checkout__description">
{
Expand Down Expand Up @@ -185,10 +189,13 @@ const PaymentRequestSection = () => {
</div>
<div className="express-checkout__label-container">
<div className="express-checkout__label">
{ __(
'Link by Stripe',
'woocommerce-gateway-stripe'
) }
<span>
{ __(
'Link by Stripe',
'woocommerce-gateway-stripe'
) }
</span>
<RecurringPaymentIcon />
</div>
<div className="express-checkout__description">
{
Expand Down Expand Up @@ -263,10 +270,13 @@ const PaymentRequestSection = () => {
</div>
<div className="express-checkout__label-container">
<div className="express-checkout__label">
{ __(
'Amazon Pay',
'woocommerce-gateway-stripe'
) }
<span>
{ __(
'Amazon Pay',
'woocommerce-gateway-stripe'
) }
</span>
<RecurringPaymentIcon />
<PaymentMethodMissingCurrencyPill
id="amazon_pay"
label={ __(
Expand Down
7 changes: 5 additions & 2 deletions client/settings/payment-request-section/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@
}

&__label {
display: inline-block;
display: inline-flex;
align-items: center;
gap: 8px;
flex-wrap: wrap;
font-size: 14px;
font-weight: 600;
line-height: 20px;
Expand All @@ -69,4 +72,4 @@
}
}
}
}
}
Loading