Skip to content

Conversation

daledupreez
Copy link
Contributor

Changes proposed in this Pull Request:

This PR is a follow-up to #4727, which added a new workflow to manually trigger e2e tests across branches. However, @diegocurbelo flagged some concerns with the descriptive text and the fact that we have two branch variables.

This PR addresses one aspect of the comment now that we have some runs in place. At present, I am still keeping the custom branch input, as I think we may have situations where we want to run workflow code from one branch (such as for a PR), but target code from another branch (generally the e2e tests). Regardless, the changes in this PR only update the description for the branch input to reflect that the code will default to the same branch as the workflow branch if no other value is specified.

Testing instructions

Inspection should be sufficient.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

No need for a changelog entry as this only impacts the field descriptions for manually running workflows in the GitHub UI.

Post merge

@daledupreez daledupreez requested review from a team, Mayisha and diegocurbelo and removed request for a team October 16, 2025 09:48
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daledupreez, LGTM.

Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants