Skip to content

Conversation

daledupreez
Copy link
Contributor

@daledupreez daledupreez commented Oct 16, 2025

Changes proposed in this Pull Request:

This PR ensures that the run-e2e-tests workflow uses the correct internal variable when selecting the Stripe keys to use for BECS and BLIK e2e tests. Prior to this fix, we would incorrectly use the standard keys and would then see failures in the tests due to the payment methods not being available.

Testing instructions

Testing for this will be via GitHub itself.

  • Navigate to https://github.com/woocommerce/woocommerce-gateway-stripe/actions/workflows/manual-e2e-tests.yml
  • Click on the "Run workflow" button
  • Ensure that you pick fix/secret-resolution-for-lpm-e2e-tests from the "Use workflow from" dropdown
  • Feel free to leave all other fields as their default values (or pick a value like release/10.0.1 for the "Branch, Tag or SHA to checkout" field)
  • Click on the "Run workflow" button
  • Verify that the becs and blik e2e tests for the workflow complete successfully

You could also take a look at https://github.com/woocommerce/woocommerce-gateway-stripe/actions/runs/18555110727, which is a run I kicked off from this branch -- you can see that the blik and becs e2e tests pass, where they failed in the previous runs.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

This PR modifies a GitHub workflow and has no user-facing impact.

Post merge

@daledupreez daledupreez requested review from a team, malithsen and wjrosa and removed request for a team October 16, 2025 08:40
@daledupreez daledupreez marked this pull request as ready for review October 16, 2025 08:40
Copy link
Contributor

@wjrosa wjrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Change looks good to me

Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants