Skip to content

Conversation

@annemirasol
Copy link

@annemirasol annemirasol commented Apr 25, 2025

Fixes STRIPE-286
Fixes #3935

Changes proposed in this Pull Request:

  • Fixes the issue where the Amazon Pay button shows up inside the Customize page for Apple Pay/Google Pay
  • Fixes the issue where location settings for Amazon Pay and Apple Pay/Google Pay can affect each other.

Testing instructions

  1. Enable the Amazon Pay feature flag: wp option update _wcstripe_feature_amazon_pay yes
  2. Enable Amazon Pay express checkout.
  3. Go to Customize, and enable it only for Checkout.
  4. Enable Apple Pay/Google Pay.
  5. Go to Customize, and disable it for Checkout.
  6. Confirm Amazon Pay shows up on checkout, while Google Pay and Apple does not, but they show up on the other pages

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@annemirasol annemirasol self-assigned this Apr 25, 2025
@annemirasol annemirasol force-pushed the fix/ece-customize-settings branch from 41a8877 to c892a4e Compare May 30, 2025 16:26
@annemirasol annemirasol closed this Jul 2, 2025
@annemirasol annemirasol reopened this Aug 13, 2025
@annemirasol annemirasol force-pushed the fix/ece-customize-settings branch 2 times, most recently from fbd5346 to 933fd7a Compare August 13, 2025 19:52
@annemirasol annemirasol marked this pull request as ready for review August 13, 2025 19:52
@annemirasol annemirasol force-pushed the fix/ece-customize-settings branch from 4aec572 to 2fff1be Compare August 13, 2025 21:27
@wjrosa wjrosa force-pushed the fix/ece-customize-settings branch from da83e53 to 08ab1e0 Compare October 24, 2025 14:20
@wjrosa wjrosa self-assigned this Oct 24, 2025
@wjrosa
Copy link
Contributor

wjrosa commented Oct 24, 2025

Hey @annemirasol! I will be tackling this PR. It still lacks some frontend changes. I will work on those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ECE payment method visibility is not independent

2 participants