Implementing the order wrapper class in abstract classes and webhook handler #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
changed the title
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- changelog.txt: Language not supported
- includes/abstracts/abstract-wc-stripe-payment-gateway-voucher.php: Language not supported
- includes/abstracts/abstract-wc-stripe-payment-gateway.php: Language not supported
- includes/class-wc-stripe-webhook-handler.php: Language not supported
- readme.txt: Language not supported
…s' of https://github.com/woocommerce/woocommerce-gateway-stripe into dev/implementing-order-wrapper-class-in-abstract-classes
📈 PHP Unit Code Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR: #4080
Changes proposed in this Pull Request:
This PR is another in a series of implementations of the proposal of #3654. This iteration implements the order wrapper class on our abstract classes and on the webhook handler class.
I had to disable some deprecation notices on replaced methods so tests could pass. Those will be re-enabled once all references get updated.
Testing instructions
Code review. Check if the tests are still passing. A slight smoke test on the checkout pages for regular payment methods would be nice: enabling methods and trying to make purchases with them on both legacy and new checkout experiences, especially voucher payment methods (Boleto, Multibanco, Oxxo) and webhook calls.
Changelog entry
Changelog Entry Comment
Comment
Post merge