Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up Amazon Pay configuration #4055

Conversation

hsingyuc
Copy link
Contributor

@hsingyuc hsingyuc commented Mar 13, 2025

Fixes #3917

Changes proposed in this Pull Request:

This PR hooks up Amazon Pay configuration settings to the admin Stripe Amazon Pay settings that check for payment-enabled/disabled.

Screen.Recording.2025-03-13.at.3.00.23.PM.mov

Testing instructions

  1. Turn the feature flag on, by setting the _wcstripe_feature_amazon_pay option to yes
  2. Verify that Amazon Pay is now available in Stripe settings
  3. Disable the Amazon Pay setting from admin payment settings
  4. The Amazon Pay setting for the merchant copy configuration in the Stripe dashboard should be disabled
  5. Turn on Amazon Pay in Stripe
  6. The Amazon Pay setting in admin should be enabled

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Hook up payment methods configuration

Post merge

@hsingyuc hsingyuc changed the base branch from develop to add/settings-synchronization March 13, 2025 15:50
@hsingyuc hsingyuc changed the title Add/hook up amazon pay configuration Hook up amazon pay configuration Mar 13, 2025
@hsingyuc hsingyuc changed the title Hook up amazon pay configuration Hook up Amazon Pay configuration Mar 13, 2025
@hsingyuc hsingyuc force-pushed the add/hook-up-amazon-pay-configuration branch from e12a4df to 27337b8 Compare March 13, 2025 18:37
@hsingyuc hsingyuc force-pushed the add/hook-up-amazon-pay-configuration branch from 27337b8 to 08af183 Compare March 13, 2025 20:31
@hsingyuc hsingyuc marked this pull request as ready for review March 14, 2025 03:15
@hsingyuc hsingyuc force-pushed the add/settings-synchronization branch from 8a29144 to a02dec7 Compare March 14, 2025 19:53
@hsingyuc
Copy link
Contributor Author

I'm closing this PR in favor of #4091.

@hsingyuc hsingyuc closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings Synchronization: Amazon Pay
1 participant