Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed customers receive English emails from Stripe if site uses formal German locale. #2357

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sun
Copy link

@sun sun commented Jun 1, 2022

Fixes #2114

Changes proposed in this Pull Request:

If a site uses the formal German locale (de_DE_formal), then the locale is not sent to Stripe. This causes all emails from Stripe to be in English instead of German.

Testing instructions

  1. Configure the site locale de_DE_formal in the WordPress language settings.
  2. Place an order.
  3. The emails sent from Stripe should be in German.

Notes

  • Stripe does not send emails when testing/sandbox mode is enabled.

  • Testing an array key lookup does not make sense. Therefore no automated tests are added.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@a-danae
Copy link
Contributor

a-danae commented Aug 10, 2023

Hey @sun 👋 !

Thank you very much for this PR. It looks good to me. It'd just need the changelog entries updated to be merged. I opened another PR - #2675 - with these changes in case you're not available.

Apologies for the delayed response and thanks again!

@github-actions github-actions bot added the Stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Default WP Site language and NOT en-US
2 participants