-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Stripe.JS library asynchronously #2118
Draft
DeanMarkTaylor
wants to merge
9
commits into
woocommerce:develop
Choose a base branch
from
DeanMarkTaylor:fix/2065-async-load-stripe-js
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Load Stripe.JS library asynchronously #2118
DeanMarkTaylor
wants to merge
9
commits into
woocommerce:develop
from
DeanMarkTaylor:fix/2065-async-load-stripe-js
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you perhaps amend with removing whitespace-only changes so PR would become easier to evaluate 🙏 |
Sure, this has been done. The whitespace changes were automatically applied formatting for WordPress Coding Standards from the IDE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2065 targeting performance issues of product and cart pages
Partially Fixes #2065
Intended to be separate from #2110 which is also addressing issues in #2065.
Changes proposed in this Pull Request:
Loads the Stripe.JS library asynchronously (with
async
attribute) as per the Stripe JS API recommendationsTargeting reduced "time to interactive" experience for users.
This is a work in-process sharing so others can review and test.
Known issues / incomplete
assets/js/stripe.js
andassets/js/stripe-pament-requiest.js
. Unsure the value this there to break out duplicated code (extra HTTP request, async complexity). Probably a separate PR.Testing instructions
So far this has not been tested at-all.
Because this directly impacts the loading of the main Stripe.JS library the main things to check are:
Post merge