[Bookings] Error and loading states for Team member filter screen #14980
+142
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfano
changed the title
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
irfano
commented
Nov 15, 2025
| bookingsRepository.observeResources().distinctUntilChanged().collect { resources -> | ||
| _uiState.update { current -> current.copy(teamMembers = listOf(TeamMember.any) + resources) } | ||
| _uiState.update { current -> | ||
| current.copy(isLoading = resources.isEmpty(), teamMembers = listOf(TeamMember.any) + resources) |
Contributor
Author
There was a problem hiding this comment.
I had to use isLoading = resources.isEmpty() here because observeResources() returns empty resources when the database is empty.
irfano
commented
Nov 15, 2025
| Column(modifier = Modifier.fillMaxWidth()) { | ||
| SkeletonView( | ||
| modifier = Modifier | ||
| .size(62.dp, 64.dp) |
Contributor
Author
There was a problem hiding this comment.
I took these sizes from the sample screen in Figma.
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../kotlin/com/woocommerce/android/ui/bookings/filter/teammember/BookingTeamMemberFilterPage.kt
Fixed
Show fixed
Hide fixed
irfano
force-pushed
the
issue/WOOMOB-1464-team-member-filter-error-loading
branch
from
0cecaf1 to
d119b59
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14980 +/- ##
============================================
- Coverage 38.46% 38.45% -0.01%
- Complexity 10233 10236 +3
============================================
Files 2155 2155
Lines 122175 122230 +55
Branches 16818 16826 +8
============================================
+ Hits 46996 47007 +11
- Misses 70412 70456 +44
Partials 4767 4767 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1464
Description
This adds handling for loading and error states when fetching team members on the Team Member filter page.
Test Steps
Tip for creating "first load" case
Use
DELETE FROM BookingResourcescommand in "App Inspection → Database Inspector → New Query" tab.Tip for the API error case
Temporarily_hardcode_siteId_for_Bookings_resources_request.patch: Use this patch to break site parameter when fetching resource.
Images/gif
Loading.webm
Error.webm
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.