[Woo POS][Local Catalog] Disable "cellular data" toggle if device doesn't have data modem #14971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
samiuelson
added
type: task
Copilot finished reviewing on behalf of
samiuelson
November 14, 2025 14:00
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to disable the "cellular data" toggle in the WooCommerce POS Local Catalog settings when the device doesn't have cellular capability (data modem).
Key Changes:
- Introduced
WooPosCellularCapabilityDetectorutility class to detect device telephony capabilities - Updated ViewModel to check cellular capability on initialization and disable the preference when unavailable
- Modified UI to visually disable and reduce opacity of the cellular data section when capability is absent
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| WooPosCellularCapabilityDetector.kt | New utility class that checks for FEATURE_TELEPHONY system feature to determine cellular capability |
| WooPosSettingsLocalCatalogViewModel.kt | Added cellular capability checking in init block and forces preference to false when capability is unavailable |
| WooPosSettingsLocalCatalogState.kt | Added hasCellularCapability boolean field to track device capability state |
| WooPosSettingsLocalCatalogScreen.kt | Updated UI to disable toggle and apply reduced opacity when device lacks cellular capability; added preview parameter provider for testing both states |
| WooPosSettingsLocalCatalogViewModelTest.kt | Added comprehensive tests for cellular capability detection and preference handling behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...e/src/main/kotlin/com/woocommerce/android/ui/woopos/util/WooPosCellularCapabilityDetector.kt
Show resolved
Hide resolved
...e/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogViewModelTest.kt
Outdated
Show resolved
Hide resolved
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
…-local-catalog-settings-in
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14971 +/- ##
=========================================
Coverage 38.44% 38.45%
- Complexity 10218 10221 +3
=========================================
Files 2152 2154 +2
Lines 122036 122052 +16
Branches 16789 16790 +1
=========================================
+ Hits 46918 46929 +11
- Misses 70359 70364 +5
Partials 4759 4759 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-1697
Description
This PR adds functionality to disable the "cellular data" toggle in the WooCommerce POS Local Catalog settings when the device doesn't have cellular capability (data modem).
Key Changes:
WooPosCellularCapabilityDetectorutility class to detect device telephony capabilitiesTest Steps
Test POS > Settings > Catalog screen on different devices:
Images/gif
Enabled
Disabled
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.