Skip to content

[WOOPRD-470][Woo POS][Product search] Implement animation of navigating to the search #13993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: trunk
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Apr 30, 2025

Closes: #WOOPRD-470

Description

  • Animation of the closing and opening of the search
  • Transition to the coupons, search states
  • Also I fixed a bug related to the padding on the empty query search state (check the second video). Before it was scrolling up to the saerch input itself, not aligned with the rest of the lists

Figma link in the issue

Steps to reproduce

  • Open the POS
  • Click on the search
  • Click on the coupons
  • Notice the animations

In debug builds, it's slower, so to test properly, use release build with FFs ON

@malinajirka your feedback is welcome here!

The tests that have been performed

Above

Images/gif

05-01--11-43.mp4
05-01--12-02.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 30, 2025

1 Error
🚫 PR requires at least one label.
1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 30, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitbc57063
Direct Downloadwoocommerce-wear-prototype-build-pr13993-bc57063.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 30, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitbc57063
Direct Downloadwoocommerce-prototype-build-pr13993-bc57063.apk

@kidinov kidinov marked this pull request as draft May 1, 2025 05:56
@kidinov kidinov requested a review from samiuelson May 1, 2025 09:44
@kidinov kidinov marked this pull request as ready for review May 1, 2025 09:50
@kidinov kidinov added this to the 22.4 milestone May 1, 2025
@samiuelson samiuelson self-assigned this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants