[2/2] `WCProductVariationModel` to Room: unit tests adjustments #13982

wzieba · 2025-04-28T13:59:03Z

Description

This PR adjusts unit tests execution after migrating WCProductVariationModel to Room in #13972 .

Testing information

Please run the app and test different scenarios when using product variations. I don't have any specific scenario in mind, as this is a core change - this will affect all features related to variations.

Tip: you can set up a store with Jurassic Ninja and import the default set of products (https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/sample-data/sample_products.csv). One of the products has a few variations already to start with.

The tests that have been performed

Smoke tests of variations.

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

2 tests are failing right now

…ven` Room and WellSql have different defaults for sort. In this test, the order doesn't matter as all items have `menuOrder=0`

Don't use incorrect `$original.id` for description: instead, use simple string to avoid any confusion. Close database on test end

wpmobilebot · 2025-04-28T14:04:17Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`3e6c29c`
	Direct Download	`woocommerce-wear-prototype-build-pr13982-3e6c29c.apk`

wpmobilebot · 2025-04-28T14:05:25Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`3e6c29c`
	Direct Download	`woocommerce-prototype-build-pr13982-3e6c29c.apk`

…rn default values Previously, functions like `VariationRepository#getProductVariationList` or `ProductDetailRepository#getCachedVariationCount` were *not* suspend. This allowed Mockito to return default values for both of the methods, respectively: empty list and 0. After recent changed, both of this functions were refactored to suspend, which caused Mockito to return `null` for them (see: mockito/mockito-kotlin#342) This comment brings back the previous behavior by mocking mentioned methods to return default values.

…_variation_to_room_tests

ParaskP7 · 2025-05-08T11:17:57Z

FYI: I am going to merge this PR into its feature branch, just like I'll first do with #13972, for the very same reasons I explained in this comment.

Cc @wzieba

ParaskP7 · 2025-05-08T18:59:08Z

FYI: As I was testing this change and running unit tests locally (in CLI), using the ./gradlew testDebugUnitTest was consistently failing on 1087 test with the below (example) stack-trace on ByteBuddyAgent, similar to the Java 11 versus 17 problem we had with Mockito a while back:

    UploadStoreUnitTest > testNumberOfAutoUploadsAttemptsCounter FAILED
        java.lang.IllegalStateException at UploadStoreUnitTest.java:46
            Caused by: java.lang.IllegalStateException at PluginInitializer.java:56
                Caused by: java.lang.reflect.InvocationTargetException at NativeConstructorAccessorImpl.java:-2
                    Caused by: org.mockito.exceptions.base.MockitoInitializationException at InlineDelegateByteBuddyMockMaker.java:260
                        Caused by: java.lang.IllegalStateException at ByteBuddyAgent.java:706

The interesting thing is that tests run successfully when I split testDebugUnitTest into multiple modules, running them as:
- ./gradlew libs:fluxc:testDebugUnitTest
- ./gradlew libs:fluxc-plugin:testDebugUnitTest
- ./gradlew libs:fluxc-tests:testDebugUnitTest

What's more interesting, after me doing the above, even ./gradlew testDebugUnitTest start working as expected (I also used the --rerun-tasks flag to make sure this unit test task runs again).

Any idea on what might the problem be, did it happen on your side? Is it maybe related to testFixtures, I can't think of any other major change that could start causing this? 🤔

PS: Also, I had no trouble running those unit tests from within the IDE (AS).

wzieba added 4 commits April 25, 2025 16:29

Fix building fluxc-plugin tests

1ce9504

2 tests are failing right now

Ignore variations order in `test that variation insert emits a flow e…

ac37d37

…ven` Room and WellSql have different defaults for sort. In this test, the order doesn't matter as all items have `menuOrder=0`

Fix WCProductStore unit tests

d967324

Don't use incorrect `$original.id` for description: instead, use simple string to avoid any confusion. Close database on test end

Apply code style

0e9cf05

wzieba added 2 commits April 28, 2025 16:36

Make the testJalapenoDebugUnitTest run

968135e

This was referenced Apr 29, 2025

Fix Buildkite test collector support when tests execution fail #13986

Merged

[1/2] WCProductVariationModel to Room: working app #13972

Merged

wzieba added the Tech Debt label Apr 30, 2025

wzieba changed the title ~~[WIP] WCProductVariationModel to Room: unit tests adjustments~~ [2/2] WCProductVariationModel to Room: unit tests adjustments Apr 30, 2025

Merge branch 'migrate_product_variation_to_room' into migrate_product…

3e6c29c

…_variation_to_room_tests

wzieba force-pushed the migrate_product_variation_to_room_tests branch from d42c2e3 to 3e6c29c Compare April 30, 2025 17:48

wzieba marked this pull request as ready for review April 30, 2025 18:02

wzieba requested a review from ParaskP7 April 30, 2025 18:02

Base automatically changed from migrate_product_variation_to_room to feature/product_variation_to_room May 8, 2025 11:20

ParaskP7 merged commit f40384f into feature/product_variation_to_room May 8, 2025
22 checks passed

ParaskP7 deleted the migrate_product_variation_to_room_tests branch May 8, 2025 11:21

ParaskP7 mentioned this pull request May 8, 2025

[WellSQL Migration] Migrate WCProductVariationModel to Room #14027

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[2/2] `WCProductVariationModel` to Room: unit tests adjustments #13982

[2/2] `WCProductVariationModel` to Room: unit tests adjustments #13982

Uh oh!

wzieba commented Apr 28, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Apr 28, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Apr 28, 2025 •

edited

Loading

Uh oh!

ParaskP7 commented May 8, 2025

Uh oh!

Uh oh!

ParaskP7 commented May 8, 2025

Uh oh!

Uh oh!

[2/2] WCProductVariationModel to Room: unit tests adjustments #13982

[2/2] WCProductVariationModel to Room: unit tests adjustments #13982

Uh oh!

Conversation

wzieba commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

The tests that have been performed

Images/gif

Reviewer (or Author, in the case of optional code reviews):

Uh oh!

wpmobilebot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ParaskP7 commented May 8, 2025

Uh oh!

Uh oh!

ParaskP7 commented May 8, 2025

Uh oh!

Uh oh!

[2/2] `WCProductVariationModel` to Room: unit tests adjustments #13982

[2/2] `WCProductVariationModel` to Room: unit tests adjustments #13982

wzieba commented Apr 28, 2025 •

edited

Loading

wpmobilebot commented Apr 28, 2025 •

edited

Loading

wpmobilebot commented Apr 28, 2025 •

edited

Loading