Add optional aria-label to search inputs. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an accessibility auditor request that the input fields for search style dropdowns include an aria-label. I've reused the option from woocommerce#43 to keep things consistent.
YuriWPY
added a commit
to WhoPlusYou/select-woo
that referenced
this pull request
May 6, 2022
…e base from upstream
YuriWPY
added a commit
to WhoPlusYou/select-woo
that referenced
this pull request
May 6, 2022
…e base from upstream
YuriWPY
added a commit
to WhoPlusYou/select-woo
that referenced
this pull request
May 6, 2022
pull requests woocommerce#44 and woocommerce#45 are merged to our code base from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an accessibility auditor request that the input fields for
search style dropdowns include an aria-label. I've reused the option from #43
to keep things consistent.
This pull request includes a
The following changes were made
If this is related to an existing ticket, include a link to it as well.
This is related to #43 and extends that to work for search style inputs.