Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added license to readme #588 #589

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added license to readme #588 #589

wants to merge 4 commits into from

Conversation

cg-cnu
Copy link

@cg-cnu cg-cnu commented Sep 7, 2017

A small, simple change 😄
Solves #588


## License

ISC

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably mention licenses of 3rd party deps.

eg:

ISC, with 3rd party modules using MIT.

Then the second part can be extended if other libs are added.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @setpixel is ok with it I can add.
But AFAIK, we usually mention only the repo's license.
At least that's what they do in the js world 😄

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants