openssf-compiler-options: allow -fdelete-null-pointer-checks to workaround abseil-cpp-related FTBFS #38781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannf
added
the
approved-to-run
octo-sts
bot
added
the
bincapz/pass
dannf
force-pushed
the
openssf-allow-fno-delete-null-pointer
branch
from
3caf110 to
1bf66d6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dannf
force-pushed
the
openssf-allow-fno-delete-null-pointer
branch
5 times, most recently
from
9a54119 to
e1ecd09
Compare
dannf
changed the title
dannf
changed the title
Using -fdelete-null-pointer to "undo" this flag is not sufficient
due to a GCC bug[*]. So let's tell the spec file to just omit
-fno-delete-null-pointer if -fdelete-null-pointer was explicitly
passed. This will give us a path to workaround build failures
in software that is incompatible with this flag (notably
abseil-cpp).
Generated with this command:
sed -i 's/-fno-delete-null-pointer-checks/%{!fdelete-null-pointer-checks:-fno-delete-null-pointer-checks}/' openssf-compiler-options/usr/lib/gcc/*/*/openssf.spec
Fixes: wolfi-dev#34075
[*] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962
Signed-off-by: dann frazier <[email protected]>
Add explicit build-dep on openssf-compiler-options so that CI orders the builds correctly. While this fixes a FTBFS, allowing a new abseil-cpp into the archive would trigger an issue in current versions of melange[*], so I'm avoiding bumping the epoch at this time. Fixes: wolfi-dev#34075 [*] chainguard-dev/melange#1651 Signed-off-by: dann frazier <[email protected]>
… OS team Updates may cause build problems until this issue is resolved: chainguard-dev/melange#1651 Signed-off-by: dann frazier <[email protected]>
…ackages We only need to override -fno-delete-null-pointer-checks for these packages to build. Add explicit build-deps on openssf-compiler-options so that CI orders the builds correctly. Also fix some incorrect issue links. This is the subset of abseil-cpp dependent packages that can benefit from this without also requiring a rebuild of abseil-cpp. Signed-off-by: dann frazier <[email protected]>
dannf
force-pushed
the
openssf-allow-fno-delete-null-pointer
branch
from
e1ecd09 to
98f77b1
Compare
justinvreeland
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abseil-cpp and its reverse dependencies (including those that vendor their own copy) FTBFS with an option from openssf-compiler-options (
-fno-delete-null-pointer-checks). A GCC bug means this can't be undone by just adding the inverse flag to CXXFLAGS or similar. This adds logic to openssf-compiler-options to not pass the breaking flag at all iff the inverse flag is provided.This also adds the inverse flag to the subset of impacted packages that do not also require a rebuild of
abseil-cppitself, because doing so would trigger an unrelated bug in melange, which I've described in a comment within.Fixes: #34075