Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkerd2/24.11.8-r0: cve remediation #36772

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 13, 2024

Copy link
Contributor Author

octo-sts bot commented Dec 13, 2024

Gen AI suggestions to solve the build error:

Based on the build log and error output, here's my analysis:

• Detected Error: Not explicitly shown in logs, but appears to fail during "go/bump" step with Go module dependency updates

• Error Category: Version/Dependency

• Failure Point: During go/bump step trying to update dependencies:

  - uses: go/bump
    with:
      deps: golang.org/x/[email protected] [email protected]

• Root Cause Analysis: The go/bump step is trying to update dependencies to specific versions that may be incompatible with the project's Go module requirements

• Suggested Fix:

  1. Update the go/bump step to use compatible versions:
  - uses: go/bump
    with:
      deps: golang.org/x/crypto@latest golang.org/x/net@latest

Or remove the go/bump step entirely if the project manages its own dependencies.

• Explanation:

  • The linkerd2 project likely has specific version requirements defined in go.mod
  • Forcing specific versions via go/bump may break dependency graph resolution
  • Letting the project manage its own dependencies through go.mod is safer
  • The idna package is part of golang.org/x/net, so specifying it separately may cause conflicts

• Additional Notes:

  • Linkerd2 is a complex Go project with many dependencies
  • Version bumps should ideally be coordinated with upstream releases
  • Consider checking go.mod in the upstream repository for proper version constraints

• References:

Try either removing the go/bump step or updating it to use latest tagged versions that are compatible with the project's requirements.

linkerd2.yaml Outdated Show resolved Hide resolved
Signed-off-by: kranurag7 <[email protected]>
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Dec 15, 2024
Signed-off-by: kranurag7 <[email protected]>

fix rust cves as well

Signed-off-by: kranurag7 <[email protected]>
@kranurag7
Copy link
Member

idna was bumped to 1.0.3 which here linkerd/linkerd2#13385 (bump url ends up bumping idna here)

@kranurag7 kranurag7 merged commit 2246286 into main Dec 16, 2024
14 checks passed
@kranurag7 kranurag7 deleted the cve-linkerd2-6f28b01479a29ec12ed2823afcccb555 branch December 16, 2024 11:14
utieyin pushed a commit to utieyin/os that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants