Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zed): pending-upstream-fix for GHSA-4grx-2x9w-596c, GHSA-c38w-74… #7284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(zed): pending-upstream-fix for GHSA-4grx-2x9w-596c, GHSA-c38w-74… #7284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions zed.advisories.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ advisories:
componentType: rust-crate
componentLocation: /usr/libexec/zed
scanner: grype
- timestamp: 2024-08-21T21:48:03Z
type: pending-upstream-fix
data:
note: There is not currently a fixed version of the rsa crate. Currently, information about private keys is leaked via a side-channel timing attack, but work is underway to migrate to a fully constant-time implementation of the cryptography algorithm. So, we must wait for this implementation to be adopted by the rsa crate maintainers.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but work is underway to migrate to a fully constant-time implementation of the cryptography algorithm

could we include a link where someone could check in to see the current status of this if they wanted? Maybe to RustCrypto/RSA#19 ?


- id: CGA-hpm6-2qvq-4337
aliases:
Expand All @@ -124,6 +128,10 @@ advisories:
componentType: rust-crate
componentLocation: /usr/libexec/zed
scanner: grype
- timestamp: 2024-08-21T21:48:03Z
type: pending-upstream-fix
data:
note: There is not currently a fixed version of the rsa crate. Currently, information about private keys is leaked via a side-channel timing attack, but work is underway to migrate to a fully constant-time implementation of the cryptography algorithm. So, we must wait for this implementation to be adopted by the rsa crate maintainers.
Comment on lines +131 to +134
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whole advisory a duplicate of the CGA-g8r9-vv23-f4jf? Like because there's a duplicate GHSA? If so can we fix this in GHSA so we don't carry the duplicate in our data too?


- id: CGA-hv6w-7882-f89g
aliases:
Expand Down