Skip to content

20250523-WC_NID_netscape_cert_type #8800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

douzzer
Copy link
Contributor

@douzzer douzzer commented May 23, 2025

wolfssl/wolfcrypt/asn.h: add a real value for WC_NID_netscape_cert_type.

See 2bae1d2 in #2503.

This change is intended to resolve this issue reported by @miyazakh:

By PR8132, it maps WC_NID_netscape_cert_type to WC_NID_undef. And by PR8655, it adds WC_NID_netscape_cert_type to wolfssl_object_inf[]. As the result, wolfSSL_OBJ_nid2sn() returns Netscape Cert Type against id==0, then Qt test becomes failure. Qt unit-test tests a custom cert extension, and it expects to return WC_NID_undef here against unknown cert extension. I think super-easy fix for Qt is removing WC_NID_netscape_cert_type addition from wolfssl_object_inf[]. However, I would like to know if it is possible to map WC_NID_netscape_cert_type another value rather than WC_NID_undef.

tested with wolfssl-multi-test.sh ... super-quick-check

@douzzer
Copy link
Contributor Author

douzzer commented May 23, 2025

retest this please

Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:
Unable to create live FilePath for wolf-linux-cloud-node-3f80e6; wolf-linux-cloud-node-3f80e6 was marked offline: Connection was broken

@SparkiDev SparkiDev assigned SparkiDev and unassigned douzzer May 25, 2025
@SparkiDev SparkiDev merged commit 6c7edeb into wolfSSL:master May 25, 2025
205 of 206 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants