-
Notifications
You must be signed in to change notification settings - Fork 888
LMS: Key ID fixup #8786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
LMS: Key ID fixup #8786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retest this please java.io.StreamCorruptedException: invalid stream header: 636F7272 |
JacobBarthelmeh
requested changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test case calling the new API.
651e415
to
75e6e7f
Compare
retest this please |
test added |
PRB-master test is complaining about:
|
Fix implementation for extracting from private key data. Add implementation that gets Key ID from wc_LmsKey.
retest this please |
JacobBarthelmeh
approved these changes
Jun 5, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix implementation for extracting from private key data. Add implementation that gets Key ID from wc_LmsKey.
Fixes zd#19925
Testing
./configure --disable-shared --enable-lms=yes,sha256-192 --enable-intelasm
Checklist