Skip to content

LMS: Key ID fixup #8786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

LMS: Key ID fixup #8786

merged 1 commit into from
Jun 5, 2025

Conversation

SparkiDev
Copy link
Contributor

Description

Fix implementation for extracting from private key data. Add implementation that gets Key ID from wc_LmsKey.

Fixes zd#19925

Testing

./configure --disable-shared --enable-lms=yes,sha256-192 --enable-intelasm

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev
Copy link
Contributor Author

retest this please

java.io.StreamCorruptedException: invalid stream header: 636F7272

@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Jun 2, 2025
@SparkiDev SparkiDev requested a review from wolfSSL-Bot June 2, 2025 22:47
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test case calling the new API.

@SparkiDev SparkiDev force-pushed the lms_kid branch 2 times, most recently from 651e415 to 75e6e7f Compare June 4, 2025 01:52
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev
Copy link
Contributor Author

test added

@JacobBarthelmeh
Copy link
Contributor

PRB-master test is complaining about:

    configure...   real 0m13.048s  user 0m9.840s  sys 0m2.412s
unescaped error code operands (missing WC_NO_ERR_TRACE()):
wolfcrypt/test/test.c:47947:    if (ret != BAD_FUNC_ARG) { ERROR_OUT(WC_TEST_RET_ENC_EC(ret), out); }
wolfcrypt/test/test.c:47949:    if (ret != BAD_FUNC_ARG) { ERROR_OUT(WC_TEST_RET_ENC_EC(ret), out); }
wolfcrypt/test/test.c:47951:    if (ret != BAD_FUNC_ARG) { ERROR_OUT(WC_TEST_RET_ENC_EC(ret), out); }
wolfcrypt/test/test.c:47953:    if (ret != BAD_FUNC_ARG) { ERROR_OUT(WC_TEST_RET_ENC_EC(ret), out); }
wolfcrypt/test/test.c:47955:    if (ret != BAD_FUNC_ARG) { ERROR_OUT(WC_TEST_RET_ENC_EC(ret), out); }
wolfcrypt/test/test.c:47957:    if (ret != BAD_FUNC_ARG) { ERROR_OUT(WC_TEST_RET_ENC_EC(ret), out); }
wolfcrypt/test/test.c:47959:    if (ret != BAD_FUNC_ARG) { ERROR_OUT(WC_TEST_RET_ENC_EC(ret), out); }

Fix implementation for extracting from private key data.
Add implementation that gets Key ID from wc_LmsKey.
@SparkiDev
Copy link
Contributor Author

retest this please

@JacobBarthelmeh JacobBarthelmeh merged commit 3078403 into wolfSSL:master Jun 5, 2025
204 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants