Recalculate suites at ssl initialization. #8757
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douzzer
requested changes
May 15, 2025
There was a problem hiding this comment.
@ColtonWilley the review question lands in your wheelhouse, according to @anhu .
| #ifndef NO_CERTS | ||
| /* Its possible that algorithm parameters were set in the ctx (ie: DH), | ||
| * recalculate cipher suites. */ | ||
| if (ssl->options.haveDH) { |
There was a problem hiding this comment.
Is it possible to test more stringently here for whether we need to recalculate? It would be nice to avoid the overhead if it's not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modifies the InitSSL() function in src/internal.c to recalculate cipher suites after copying DH parameters from the context to the SSL object.
Fixes ZD19827