DataViewer Pagination #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-salman
commented
Feb 5, 2025
john-salman
commented
- Added chunk based loading for requests with over 500 observations
- Moved logic from plot and table up to parent component
- Added pagination input and number input for changing chunk size and records per page
- Fixed close button logic in ChartDialog so opening the modal again doesnt require a double click
- Added chunk based loading for requests with over 500 observations - Moved logic from plot and table up to parent component - Added pagination input and number input for changing chunk size and records per page - Fixed close button logic in ChartDialog so opening the modal again doesnt require a double click
C-Loftus
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
For WMO folks, John is the new frontend dev associated with us at CGS/Lincoln.
I went over the PR with him and it looks good to me. Maaike, I think we may need to enable something in the repo to get the github actions to work for other contributors since only playwright appears to be running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.