-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add Pin Manager UI for pin status and button state debugging #5122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: DedeHai <[email protected]>
Co-authored-by: DedeHai <[email protected]>
Co-authored-by: DedeHai <[email protected]>
|
@copilot since usermod names are known by the controller, if a pin is owned by a UM, use the UM name string and omit the UM list in JS. |
…/LOW text, rename Caps to Functions Co-authored-by: DedeHai <[email protected]>
Addressed in b596fca:
Note: Usermod name mapping kept in JS since there's no simple |
|
@copilot now you made it worse: the unknown pins are unuseable so omit those, you omitted all available pins. also touch button still does not show the state like the normal buttons do. |
…ti Relay support Co-authored-by: DedeHai <[email protected]>
Fixed in 1071bab:
|
|
@copilot you are now reading touch states correctly but touch buttons still do not show the state in the UI |
…ns and platforms Co-authored-by: DedeHai <[email protected]>
|
@copilot touch pins still do not show ANY state dot. please rethink what could be the issue. |
|
@softhack007 did you ever try to implement something like this? Its still a prototype version but most of the functionality is there. copilot is at its wits end it seems though but ouputs and inputs update dynamically, I can see a dot turn green if I pull down a button pin. |
…t in btnPin array Co-authored-by: DedeHai <[email protected]>
Co-authored-by: DedeHai <[email protected]>
Fixed in ccf0702:
|
|
@copilot move the UI code to a seperate htm file named settingspins, add a button in the settings.htm below the LED settings and remove it from the info tab. |
…nfo tab Co-authored-by: DedeHai <[email protected]>
Done in 54db224:
The "update the pin info throughout the config pages" part would require significant additional changes to settings_leds.htm and other config pages - should I proceed with that as a separate update? |
|
@copilot instead of doing a re-implementation of code in button.cpp, modify button.cpp with helper functions such that you can reuse functions to detect a shortPressAction and longPressAction, I do not think that doublePressAction is useful for debuggin. |
…isplay Co-authored-by: DedeHai <[email protected]>
Done in 9dd3759:
|
|
@copilot rebase your work to the latest changes in main. also use the existing /settings/s.js?p=2 which already contains some pin info and extend it to contain touch capability. |
Co-authored-by: DedeHai <[email protected]>
Done in bb8deb5:
Note: Rebasing isn't possible as I cannot push rebased commits (force push not available). Please let me know if you'd like to manually rebase the branch. |
|
@copilot I updated from main, please fix for new button handling |
Co-authored-by: DedeHai <[email protected]>
|
@copilot on ESP8266, GPIO17 is not defined, only 0-16 exist. also on any of the ESP32 variants, ADC2 channels can not be used as its occupied by wifi. |
Co-authored-by: DedeHai <[email protected]>
Fixed in c281180:
|






t) to JSON outputisButtonPressed()from button.cpp instead of re-implementing button state detection/settings/s.js?p=2endpoint for touch capability infoappendGPIOinfo()to included.touch_gpioarraystd::vector<Button> buttonsrfield) for touch buttonsChanges Made
rfield) for touch buttons - useful for debugging threshold settingsOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.