Feature/publish token authorization status from auth module#1
Feature/publish token authorization status from auth module#1
Conversation
| - CertChainError | ||
| - ContractCancelled | ||
| TokenValidationStatus: | ||
| description: Ongoing token validation status |
There was a problem hiding this comment.
Maybe add descriptions of the states here as well?
There was a problem hiding this comment.
Aren't states self descriptive? What should I write there?
TokenValidationStatus:
description: >-
Ongoing token validation status.
Idle mean that no token is currently processed.
The first state after receiving the token is Processing.
As soon as the token gets accepted, Accepted state is published.
Whenever token gets rejected, Rejected is published.
type: string
But this sounds weird
| enum: | ||
| - Idle | ||
| - Processing | ||
| - Accepted |
There was a problem hiding this comment.
Should we have different enums for accepted and used to stop and accepted and used to start a session?
There was a problem hiding this comment.
What's the difference? Token is validated and accepted, right?
There was a problem hiding this comment.
Depending on what the use case is I think it does make a difference if the token is used to stop or start a session
There was a problem hiding this comment.
I disagree. The following event will come later on. I think they added those return values just to make the code testable
There was a problem hiding this comment.
I don't understand - what is the following event ?
There was a problem hiding this comment.
SessionEvent -> TransactionStarted/TransactionStopped
There was a problem hiding this comment.
TransactionStarted: Signaled when a transaction has been started. Transaction starts at the point that all conditions for charging are met: EV is connected and user has been authorized
TransactionFinished: Signaled when the transaction finished. Transaction finishes at the point where one of the preconditions for charging irrevocably becomes false: When a user swipes to stop the transaction and the stop is authorized.
There was a problem hiding this comment.
My thinking was that we might want to differentiate if the token was used to stop (e.x show a yellow check mark) or to start (e.x Show a Green Check Mark)
Do you suggest to use the session event for this?
There was a problem hiding this comment.
As discussed offline, we can always extend this message later
I'm creating a PR
6ae41fd to
cbe8e65
Compare
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
cbe8e65 to
ee11038
Compare
Signed-off-by: Wojciech Kula <wku@qwello.eu>
feca3f6 to
3352ef6
Compare
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
* Add bazel support (#1) * Fix CMake build for Rust (EVerest#3) * Rust: update everest-framework (EVerest#17) * Update framework version in bazel dependencies * Update framework revision in rust --------- Signed-off-by: Dima Dorezyuk <ddo@qwello.eu> Signed-off-by: Evgeny Petrov <evgeny@epetrov.net> Co-authored-by: Dima Dorezyuk <ddo@qwello.eu>
Before we go with that to EVerest, let's do internal review