Skip to content

Comments

Feature/publish token authorization status from auth module#1

Open
wku12 wants to merge 9 commits intomainfrom
feature/publish_token_authorization_status_from_auth_module
Open

Feature/publish token authorization status from auth module#1
wku12 wants to merge 9 commits intomainfrom
feature/publish_token_authorization_status_from_auth_module

Conversation

@wku12
Copy link
Owner

@wku12 wku12 commented Oct 23, 2023

Before we go with that to EVerest, let's do internal review

- CertChainError
- ContractCancelled
TokenValidationStatus:
description: Ongoing token validation status

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add descriptions of the states here as well?

Copy link
Owner Author

@wku12 wku12 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't states self descriptive? What should I write there?

  TokenValidationStatus:
    description: >-
      Ongoing token validation status. 
      Idle mean that no token is currently processed.
      The first state after receiving the token is Processing.
      As soon as the token gets accepted, Accepted state is published.
      Whenever token gets rejected, Rejected is published.
    type: string

But this sounds weird

enum:
- Idle
- Processing
- Accepted

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have different enums for accepted and used to stop and accepted and used to start a session?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference? Token is validated and accepted, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on what the use case is I think it does make a difference if the token is used to stop or start a session

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. The following event will come later on. I think they added those return values just to make the code testable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand - what is the following event ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SessionEvent -> TransactionStarted/TransactionStopped

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TransactionStarted: Signaled when a transaction has been started. Transaction starts at the point that all conditions for charging are met: EV is connected and user has been authorized
TransactionFinished: Signaled when the transaction finished. Transaction finishes at the point where one of the preconditions for charging irrevocably becomes false: When a user swipes to stop the transaction and the stop is authorized.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was that we might want to differentiate if the token was used to stop (e.x show a yellow check mark) or to start (e.x Show a Green Check Mark)

Do you suggest to use the session event for this?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we can always extend this message later
I'm creating a PR

@wku12 wku12 force-pushed the feature/publish_token_authorization_status_from_auth_module branch from 6ae41fd to cbe8e65 Compare October 24, 2023 13:47
wku12 added 5 commits October 26, 2023 12:19
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Wojciech Kula <wku@qwello.eu>
@wku12 wku12 force-pushed the feature/publish_token_authorization_status_from_auth_module branch from cbe8e65 to ee11038 Compare October 26, 2023 10:19
Signed-off-by: Wojciech Kula <wku@qwello.eu>
@wku12 wku12 force-pushed the feature/publish_token_authorization_status_from_auth_module branch from feca3f6 to 3352ef6 Compare November 2, 2023 12:44
wku12 and others added 3 commits November 10, 2023 07:22
Signed-off-by: Wojciech Kula <wku@qwello.eu>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
wku12 pushed a commit that referenced this pull request Sep 11, 2024
* Add bazel support (#1)
* Fix CMake build for Rust (EVerest#3)
* Rust: update everest-framework (EVerest#17)
* Update framework version in bazel dependencies
* Update framework revision in rust

---------

Signed-off-by: Dima Dorezyuk <ddo@qwello.eu>
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
Co-authored-by: Dima Dorezyuk <ddo@qwello.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants