-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add a regex filename filter #310
Conversation
Another possibility would be to use something like https://docs.python.org/3/library/fnmatch.html that may be closer to what you expect of the behavior of a ".gitignore". |
@o-laurent Looking good, thanks. Btw, do you need the command line option? |
@wkentaro, I won't need the CLI option. Of course, feel free to remove it if you think that your lib would be better without/it is not necessary. By the way, I just pulled your changes from #308. This PR also fixes a lint issue. |
@o-laurent I think #317 is more simple yet flexible. Please check it out. |
Simpler, I'd say that it depends on the use case, but more flexible, definitely. It will solve my problem nicely. Thanks @wkentaro for your help! |
Hi @wkentaro,
I followed the directions that you provided in our discussion.
I remain available for any questions or updates.
This PR depends on #308.