Chioma Amanda Mmegwa iOSTestingBootcamp #9
Conversation
Implement Api Call
Implement Unit Test
There was a problem hiding this comment.
Hey Chisma! Amazing work done here! 🚀 🎸
You are on 98.4% of code coverage which it is great. I wasn't able to find bigger issues other than some clean code practices and something more. Check those comments. So, basically it is cool how you learned and implemented TDD on this project. Keep learning more about testing and I would recommend you to learn more about swift code style, SOLID and SoC design principles, memory management (ARC, Capture Lists, Reference Types) and just to finish, I know you could be buried with work and other stuff, but It could have been great if you updated the UI of the app. Congratulations again! Keep learning new stuff :D.
| protocol FeedDataManagerProtocol { | ||
| func fetch(completion: (Result<[TweetCellViewModel], Error>) -> Void) | ||
| func fetch(completion: @escaping (Result<[TweetCellViewModel], Error>) -> Void) |
| protocol FeedDataManagerProtocol { | ||
| func fetch(completion: (Result<[TweetCellViewModel], Error>) -> Void) | ||
| func fetch(completion: @escaping (Result<[TweetCellViewModel], Error>) -> Void) | ||
| } | ||
|
|
||
| class FeedDataManager: FeedDataManagerProtocol { |
There was a problem hiding this comment.
You could add the final key for this class.
|
|
||
| func fetch(completion: @escaping (Result<[TweetCellViewModel], Error>) -> Void) { | ||
| let url = URL(string: "https://gist.githubusercontent.com/ferdelarosa-wz/0c73ab5311c845fb7dfac4b62ab6c652/raw/6a39cffe68d87f1613f222372c62bd4e89ad06fa/tweets.json") | ||
| guard let url else { return } |
There was a problem hiding this comment.
It is great to see that you are avoiding force unwrapping.
| completion(.failure(error)) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Extra empty line is not needed.
| @@ -27,13 +27,13 @@ class FeedViewModel { | |||
| self.dataManager = dataManager | |||
| } | |||
| func fetchTimeline() { | |||
| dataManager.fetch { result in | |||
| dataManager.fetch { [weak self] result in | |||
| private class FakeSession: URLSession { | ||
| var data: Data? | ||
| var error: Error? | ||
|
|
||
| override func dataTask(with request: URLRequest, completionHandler: @escaping (Data?, URLResponse?, Error?) -> Void) -> URLSessionDataTask { | ||
|
|
||
| MockDataTask { | ||
| completionHandler(self.data, nil, self.error) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private class MockDataTask: URLSessionDataTask { | ||
| private let closure: () -> () | ||
|
|
||
| init(closure: @escaping () -> ()) { | ||
| self.closure = closure | ||
| } | ||
|
|
||
| override func resume() { | ||
| closure() | ||
| } | ||
| } |
There was a problem hiding this comment.
This clases should go on its own files
| override func tearDown() { | ||
| super.tearDown() | ||
| sut = nil | ||
| session = nil | ||
| } |
There was a problem hiding this comment.
This should go above. after the set up.
| @testable import MiniBootcamp | ||
|
|
||
| final class TweetModelTests: XCTestCase { | ||
| func test_mapToViewModel() { |
There was a problem hiding this comment.
You could leave and extra line after the class declaration.
| user: User( | ||
| followersCount: 20, | ||
| name: "test", | ||
| screenName: "screenName", | ||
| description: "description", | ||
| location: "location", | ||
| createdAt: "createdAt", | ||
| profileBackgroundColor: "backgroundColor", | ||
| profileImageURL: "imageUrl", | ||
| profileBackgroundImageURL: "backgroundImageUrl" | ||
| ), |
There was a problem hiding this comment.
For readability, declare the user property apart and then use it to build the tweet struct.
| @testable import MiniBootcamp | ||
|
|
||
| final class TweetModelTests: XCTestCase { | ||
| func test_mapToViewModel() { |
There was a problem hiding this comment.
You should be consistent on the naming convention of your test methods. Either use this snake case or the camel case used on the other tests. Not big deal but consistency is great.
Created to be able to comment and leave feedback.