Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): expose stylesheet types in package exports #2924

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix(runtime): expose stylesheet types in package exports #2924

merged 1 commit into from
Nov 21, 2023

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Nov 20, 2023

This pr introduces the addition of @stylable/runtime/stylesheet mapping to the exports field in the package.json of the runtime package.

This is specifically aimed at facilitating projects that utilize TypeScript with moduleResolution: node16 in conjunction with the global stylesheet types approach.

@idoros idoros added bug Unexpected behavior or exception integration Bundler, test-runner and node labels Nov 20, 2023
@idoros idoros requested a review from barak007 November 20, 2023 10:38
@idoros idoros self-assigned this Nov 20, 2023
@barak007 barak007 merged commit c572eb5 into master Nov 21, 2023
@barak007 barak007 deleted the ido/runtime-package-export-stylesheet branch November 21, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees

@idoros idoros

Labels
bug Unexpected behavior or exception integration Bundler, test-runner and node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idoros @barak007