Repository navigation
wix-app: one SDK lookup call per feature, with the call shape #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kobiburnley
wants to merge
19
commits into
main
Choose a base branch
from
wix-app/sdk-lookup-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
11f3e1a
wix-app: one SDK lookup call per feature, with the call shape
kobiburnley 9dd66aa
wix-app: sdk-lookup takes the public signature and the spec's filter …
kobiburnley fdc2e36
wix-app: sdk-lookup names the index file's path, points other methods…
kobiburnley ddf1ff8
wix-app: sdk-lookup derives every record from the .d.ts files, drop s…
kobiburnley 1788bff
wix-app: sdk-lookup prints the keys of a search, query or list call's…
kobiburnley e8c1a98
wix-app: DATA_SOURCES.md back under the 10,000-char fetch limit
kobiburnley 7e78a4e
Merge remote-tracking branch 'origin/main' into wix-app/sdk-lookup-poc
kobiburnley 2686f42
ci: test wix-app's sdk-lookup.cjs on trimmed copies of real SDK packages
kobiburnley ed08857
wix-app: sdk-lookup prints a builder's query-object form, and keeps a…
kobiburnley b4c919e
wix-app: sdk-lookup sets a query form's keys last, the same order as …
kobiburnley 3fbce34
wix-app: say how to key a map by an SDK enum without TS7053
kobiburnley 380e7f3
Merge remote-tracking branch 'origin/main' into wix-app/sdk-lookup-poc
kobiburnley dec274f
wix-app: the SDK lookup says how to apply a search term (#1745)
kobiburnley 4aa2611
Merge remote-tracking branch 'origin/main' into wix-app/sdk-lookup-poc
kobiburnley 6cee451
wix-app: address the #1684 review of the SDK lookup
kobiburnley 0c32c1f
skill-eval: rebuild dist for the tag-globs change in evalforge-core
kobiburnley 1688e7c
wix-app: the SDK lookup ranks shared namespaces by the module map, no…
kobiburnley 14e147a
wix-app: with no module map row, the lookup prefers the package named…
kobiburnley 6500d22
wix-app: the SDK lookup prints the entity type and package lines befo…
kobiburnley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derive-tags.ts:21ignoresscripts/**, so changes tosdk-lookup.cjsorsdk-curated.jsonrun no evals (as with #1745), yet the skill tells the agent to trust the script over the typings. I suggest mapping these files to thesdk-module-map/dashboard-pagetags.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6cee451. The skill gate has a new
tag-globsinput (glob: tag[, tag]lines), checked beforeignore-globs.evalforge-wix-app-gate.ymlmapsscripts/sdk-lookup.cjsandscripts/sdk-curated.jsontosdk-module-mapanddashboard-page.deriveTags, the config and the README are updated, with tests. The gate runs the action frommain, so the mapping takes effect after this PR merges.