A rocover fix for the deep circular object 'Maximum call stack size e… #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xceeded' error in defaultEquality function
|
In reality in many cases we don't need to compare deep levels, so the fix works in most cases. I think it should be warned for those who are using this plugin with many nodes and very deep levels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an error rocovery fix for the deep circular object 'Maximum call stack size exceeded' error for angular.equals in defaultEquality function.
In some cases with deep circular object it still gives error which is probably caused by the equivalence of two object in the shallow levels and more comparisons in the deep levels.