-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(InputBar): files dropzone draft [WPB-16106] #18774
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18774 +/- ##
==========================================
- Coverage 45.68% 45.44% -0.25%
==========================================
Files 988 1014 +26
Lines 28042 28191 +149
Branches 6315 6336 +21
==========================================
Hits 12811 12811
- Misses 13638 13787 +149
Partials 1593 1593 |
"conversationFileUploadFailedTooLargeFilesMessage": "Please select files smaller than {maxSize}MB.", | ||
"conversationFileUploadFailedTooLargeImagesMessage": "Please select images smaller than {maxSize}MB.", | ||
"conversationFileUploadFailedTooLargeFilesAndImagesMessage": "Please select files smaller than {maxImageSize}MB and images smaller than {maxFileSize}MB.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also provide unit ? MB/GB/ etc? WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we don't allow big files, like in GB (max is 25/50 MB, depends if user is in a team), so I would leave it like that 🤷♂️ If we would have a need, then sure
files: [], | ||
addFiles: newFiles => | ||
set(state => ({ | ||
files: [...newFiles, ...state.files], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be ...state.files first? Because it will override newFiles if will be the same :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case was to have new uploaded files first, on top of the list - then we can see there's a new file
src/script/components/InputBar/FilePreviews/VideoPreviewCard/VideoPreviewCard.tsx
Outdated
Show resolved
Hide resolved
|
Description
About the change:
Animation library:
Demo
Uploading and deleting multiple files:
upload-files.mov
[Error] Too many files:
too-many-files.mov
[Error] Images too large:
too-large-image.mov
[Error] Files and/or images too large:
files-too-large.mov
Checklist