Skip to content

Conversation

@saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 5, 2025

BugWPB-22232 [Android] wrong bubble colors for multipart assets


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The bubble colors for multipart assets haven’t been updated after the recent changes in bubbles designs.

Solutions

Updated bubble colors for multipart assets and fixed borders/cropping for some types.
Removed some outdated color scheme fields that should be already removed.
Implemented a preview object for multipart view model and mocks to be able to preview multipart assets message type.

Attachments (Optional)

Before After
multipart_before multipart_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
18.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.41%. Comparing base (d078be5) to head (031de5f).

Files with missing lines Patch % Lines
...getypes/multipart/MultipartAttachmentsViewModel.kt 81.25% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4466      +/-   ##
===========================================
- Coverage    47.43%   47.41%   -0.02%     
===========================================
  Files          536      536              
  Lines        18127    18130       +3     
  Branches      3068     3068              
===========================================
- Hits          8599     8597       -2     
- Misses        8602     8607       +5     
  Partials       926      926              
Files with missing lines Coverage Δ
...messagetypes/multipart/MultipartAttachmentsView.kt 0.00% <ø> (ø)
...ssagetypes/multipart/standalone/PdfAssetPreview.kt 0.00% <ø> (ø)
...agetypes/multipart/standalone/VideoAssetPreview.kt 0.00% <ø> (ø)
...getypes/multipart/MultipartAttachmentsViewModel.kt 57.83% <81.25%> (-4.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d078be5...031de5f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saleniuk saleniuk added this pull request to the merge queue Dec 8, 2025
Merged via the queue into develop with commit cfc436a Dec 8, 2025
13 of 15 checks passed
@saleniuk saleniuk deleted the fix/wrong-bubble-colors-for-multipart-assets branch December 8, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants