Skip to content

Conversation

istankovic
Copy link
Member

Use nightly for local dev environment, but stable for CI (except for rustfmt and clippy).

@istankovic istankovic requested a review from a team as a code owner October 15, 2025 11:44
Copy link
Contributor

@fewerner fewerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two things:

  1. We should probably add a script to update the rust-version of each crate as we did in core-crypto
  2. Reason for the nightly toolchain were the formatting flags, I would add these here or in a separate PR and format the repo once.

@istankovic
Copy link
Member Author

I have two things:

1. We should probably add a script to update the rust-version of each crate as we did in core-crypto

I think that is unnecessary since we can just reuse the script from core-crypto (and so avoid having to maintain two scripts).

2. Reason for the nightly toolchain were the formatting flags, I would add these here or in a separate PR and format the repo once.

I did that and it was a no-op -- apparently no formatting changes are necessary.

@fewerner
Copy link
Contributor

Please take a look at the rustfmt.toml of core-crypto. Some flags are missing, we should probably copy that file.

@istankovic istankovic force-pushed the ivan/be-consistent-with-core-crypto branch from 4f6e4d5 to b1a44c3 Compare October 17, 2025 07:52
@istankovic istankovic requested a review from fewerner October 17, 2025 07:53
Copy link
Contributor

@fewerner fewerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@istankovic istankovic merged commit b1a44c3 into main Oct 17, 2025
16 checks passed
@istankovic istankovic deleted the ivan/be-consistent-with-core-crypto branch October 17, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants