Skip to content

Conversation

coriolinus
Copy link
Contributor

What's new in this PR

Per edition guide.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@coriolinus coriolinus requested a review from a team as a code owner February 21, 2025 11:47
@coriolinus coriolinus force-pushed the prgn/chore/2024-edition branch from ff34ae2 to f112fb8 Compare February 21, 2025 13:27
@coriolinus coriolinus force-pushed the prgn/chore/2024-edition branch 3 times, most recently from 68ecb38 to f4a6bec Compare February 24, 2025 08:49
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.93%. Comparing base (99e29fb) to head (610a18b).
Report is 5 commits behind head on main.

❌ Your patch status has failed because the patch coverage (41.66%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   79.91%   79.93%   +0.01%     
==========================================
  Files          49       49              
  Lines        4302     4301       -1     
==========================================
  Hits         3438     3438              
+ Misses        864      863       -1     

Copy link
Member

@istankovic istankovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coriolinus coriolinus force-pushed the prgn/chore/2024-edition branch from f4a6bec to 610a18b Compare February 24, 2025 09:05
@coriolinus coriolinus merged commit 610a18b into main Feb 24, 2025
15 checks passed
@coriolinus coriolinus deleted the prgn/chore/2024-edition branch February 24, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants