-
Notifications
You must be signed in to change notification settings - Fork 7
fix: suppress buffer error for mls decrypt transaction [WPB-16233] 🍒 #3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: suppress buffer error for mls decrypt transaction [WPB-16233] 🍒 #3306
Conversation
…3305) * fix: suppress buffer error for mls decrypt transaction * detekt fix * error check fix * detekt fix
|
|
Branch | fix/suppress-mls-buffer-error-cherry-pick |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
flag.
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 681.70 µs |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 404,891.87 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,343,599.58 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 26,643.68 µs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3306 +/- ##
===========================================
+ Coverage 50.69% 50.70% +0.01%
===========================================
Files 1611 1611
Lines 58162 58174 +12
Branches 5249 5254 +5
===========================================
+ Hits 29485 29500 +15
+ Misses 26649 26642 -7
- Partials 2028 2032 +4 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3416 Passed, 110 Skipped, 1m 4.87s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
BufferedFutureMessage
exception instead of buffering and persisting the message.Causes
MlsException.BufferedFutureMessage
(wrapped inCoreCryptoException.Mls
) within the transactional decryption flow.Solutions
decryptMessage
flow to wrap calls in a transactional API and specifically catchBufferedFutureMessage
exceptions, allowing the transaction to commit and the message to be buffered rather than rolled back.