Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore subconversation message fail system message [WPB-15684] #3245

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 24, 2025

BugWPB-15684 [Android] SubConversation messages sends system messages when fails to decrypt


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Previously, system messages were being sent for MLS messages even when the subConversationId was present. This behavior was incorrect because sub-conversations should not trigger system messages for decryption errors.

Solutions

  1. Sub-Conversation Check:

    • Updated the code to skip sending system messages if subConversationId is not null when handling InformUser failures.
    • This ensures that sub-conversation-specific events are handled correctly without unnecessary system messages.
  2. Comprehensive Testing:

    • Added a new test case to verify that handleDecryptionError is not invoked when subConversationId is present.
    • Ensured that all related scenarios are covered to prevent regressions.

@Garzas Garzas self-assigned this Jan 24, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 24, 2025
@Garzas Garzas enabled auto-merge January 24, 2025 10:49
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Test Results

3 348 tests  +1   3 240 ✅ +1   5m 22s ⏱️ - 1m 2s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 0e89498. ± Comparison against base commit 55e6c38.

♻️ This comment has been updated with latest results.

@Garzas Garzas disabled auto-merge January 24, 2025 11:07
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.52%. Comparing base (55e6c38) to head (0e89498).

Files with missing lines Patch % Lines
...ver/conversation/message/NewMessageEventHandler.kt 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3245   +/-   ##
==================================================
  Coverage              54.51%   54.52%           
==================================================
  Files                   1250     1250           
  Lines                  36554    36555    +1     
  Branches                3698     3699    +1     
==================================================
+ Hits                   19929    19933    +4     
+ Misses                 15224    15222    -2     
+ Partials                1401     1400    -1     
Files with missing lines Coverage Δ
...ver/conversation/message/NewMessageEventHandler.kt 84.61% <0.00%> (+1.12%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e6c38...0e89498. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/ignore-subconversation-message-fail-system-message
Commit report: 3d71598
Test service: kalium-jvm

✅ 0 Failed, 3240 Passed, 108 Skipped, 59.81s Total Time

@Garzas Garzas added this pull request to the merge queue Jan 24, 2025
Merged via the queue into release/candidate with commit b471e2a Jan 24, 2025
22 checks passed
@Garzas Garzas deleted the fix/ignore-subconversation-message-fail-system-message branch January 24, 2025 12:00
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants