-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore subconversation message fail system message [WPB-15684] #3245
fix: ignore subconversation message fail system message [WPB-15684] #3245
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3245 +/- ##
==================================================
Coverage 54.51% 54.52%
==================================================
Files 1250 1250
Lines 36554 36555 +1
Branches 3698 3699 +1
==================================================
+ Hits 19929 19933 +4
+ Misses 15224 15222 -2
+ Partials 1401 1400 -1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3240 Passed, 108 Skipped, 59.81s Total Time |
…3245) (#3246) Co-authored-by: Jakub Żerko <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Previously, system messages were being sent for MLS messages even when the
subConversationId
was present. This behavior was incorrect because sub-conversations should not trigger system messages for decryption errors.Solutions
Sub-Conversation Check:
subConversationId
is not null when handlingInformUser
failures.Comprehensive Testing:
handleDecryptionError
is not invoked whensubConversationId
is present.