refactor: move commit-producing APIs to ConversationGuard [WPB-15587]

[coriolinus]

What's new in this PR

---

PR Submission Checklist for internal contributors

• The PR Title
  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Bencher Report

Branch	prgn/refactor/15587-commit-producing-apis
Testbed	ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	milliseconds (ms)
Commit add f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	19.70
Commit add f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	7.14
Commit add f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	9.67
Commit add f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	12.24
Commit add f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	15.34
Commit add f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	17.42
Commit add f(number clients)/cs1/mem/1002	📈 view plot 🚷 view threshold	994.94
Commit add f(number clients)/cs1/mem/2	📈 view plot 🚷 view threshold	7.19
Commit add f(number clients)/cs1/mem/202	📈 view plot 🚷 view threshold	86.18
Commit add f(number clients)/cs1/mem/402	📈 view plot 🚷 view threshold	223.09
Commit add f(number clients)/cs1/mem/602	📈 view plot 🚷 view threshold	430.97
Commit add f(number clients)/cs1/mem/802	📈 view plot 🚷 view threshold	683.48
Commit pending proposals f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	117.85
Commit pending proposals f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	28.63
Commit pending proposals f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	46.32
Commit pending proposals f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	61.47
Commit pending proposals f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	80.49
Commit pending proposals f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	95.56
Commit pending proposals f(pending size)/cs1/mem/1	📈 view plot 🚷 view threshold	19.33
Commit pending proposals f(pending size)/cs1/mem/101	📈 view plot 🚷 view threshold	116.24
Commit pending proposals f(pending size)/cs1/mem/21	📈 view plot 🚷 view threshold	36.35
Commit pending proposals f(pending size)/cs1/mem/41	📈 view plot 🚷 view threshold	58.44
Commit pending proposals f(pending size)/cs1/mem/61	📈 view plot 🚷 view threshold	77.10
Commit pending proposals f(pending size)/cs1/mem/81	📈 view plot 🚷 view threshold	96.16
Commit remove f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	27.96
Commit remove f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	7.00
Commit remove f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	9.51
Commit remove f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	12.39
Commit remove f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	18.31
Commit remove f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	21.99
Commit remove f(number clients)/cs1/mem/1002	📈 view plot 🚷 view threshold	30.97
Commit remove f(number clients)/cs1/mem/2	📈 view plot 🚷 view threshold	138.57
Commit remove f(number clients)/cs1/mem/202	📈 view plot 🚷 view threshold	116.00
Commit remove f(number clients)/cs1/mem/402	📈 view plot 🚷 view threshold	94.75
Commit remove f(number clients)/cs1/mem/602	📈 view plot 🚷 view threshold	73.69
Commit remove f(number clients)/cs1/mem/802	📈 view plot 🚷 view threshold	51.41
Commit update f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	138.71
Commit update f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	7.12
Commit update f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	34.01
Commit update f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	60.11
Commit update f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	87.52
Commit update f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	112.77

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 96.16477% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.94%. Comparing base (b8b370d) to head (07176dc).

Files with missing lines	Patch %	Lines
crypto-ffi/src/generic/context/mod.rs	0.00%	25 Missing ⚠️
crypto-ffi/src/generic/mod.rs	0.00%	1 Missing ⚠️
.../src/mls/conversation/conversation_guard/commit.rs	98.92%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   78.13%   78.94%   +0.81%     
==========================================
  Files         112      113       +1     
  Lines       20280    20720     +440     
==========================================
+ Hits        15845    16358     +513     
+ Misses       4435     4362      -73     

Files with missing lines	Coverage Δ
crypto/src/e2e_identity/rotate.rs	92.16% <100.00%> (+0.13%)	⬆️
crypto/src/mls/buffer_external_commit.rs	98.32% <100.00%> (+0.07%)	⬆️
crypto/src/mls/conversation/buffer_messages.rs	98.41% <100.00%> (+0.04%)	⬆️
crypto/src/mls/conversation/commit.rs	88.06% <100.00%> (+4.33%)	⬆️
crypto/src/mls/conversation/commit_delay.rs	96.35% <100.00%> (+0.09%)	⬆️
...pto/src/mls/conversation/conversation_guard/mod.rs	87.80% <100.00%> (ø)
crypto/src/mls/conversation/decrypt.rs	79.52% <100.00%> (+1.93%)	⬆️
crypto/src/mls/conversation/duplicate.rs	95.54% <100.00%> (+0.51%)	⬆️
...rypto/src/mls/conversation/leaf_node_validation.rs	95.08% <100.00%> (+0.25%)	⬆️
crypto/src/mls/conversation/merge.rs	84.66% <100.00%> (+0.55%)	⬆️
... and 12 more

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b370d...07176dc. Read the comment docs.