Skip to content

Commit

Permalink
ENABLE_LIB_ONLY instead of building only the nghttp2 target
Browse files Browse the repository at this point in the history
This configuration option is available as of nghttp2 1.9.0, so there
shouldmn't be issues if we would need to rebuild on old version.
  • Loading branch information
cmb69 committed Nov 27, 2024
1 parent b2929ac commit fc0663c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/nghttp2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ jobs:
id: virtuals
run: powershell winlib-builder/scripts/compute-virtuals -version ${{github.event.inputs.php}} -arch ${{matrix.arch}}
- name: Configure nghttp2
run: cd nghttp2 && cmake -G "Visual Studio 17 2022" -A ${{steps.virtuals.outputs.msarch}} -T ${{steps.virtuals.outputs.msts}} -DCMAKE_SYSTEM_VERSION=${{steps.virtuals.outputs.winsdk}} -DBUILD_STATIC_LIBS=ON .
run: cd nghttp2 && cmake -G "Visual Studio 17 2022" -A ${{steps.virtuals.outputs.msarch}} -T ${{steps.virtuals.outputs.msts}} -DCMAKE_SYSTEM_VERSION=${{steps.virtuals.outputs.winsdk}} -DENABLE_LIB_ONLY=ON -DBUILD_STATIC_LIBS=ON .
- name: Build nghttp2
run: cd nghttp2 && cmake --build . --config RelWithDebInfo --target nghttp2
run: cd nghttp2 && cmake --build . --config RelWithDebInfo
- name: Install nghttp2
run: |
cd nghttp2
Expand Down

0 comments on commit fc0663c

Please sign in to comment.