Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to vanilla curl 8.9.0 #21

Closed
wants to merge 1 commit into from
Closed

Update to vanilla curl 8.9.0 #21

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 25, 2024

I've downloaded the curl-8.9.0.zip from https://curl.se/download/, checked the signature, and replaced all existing files with the new ones. Then I built for PHP 8.3 staging, put the new build in my deps folder, built PHP-8.3 (both x64 and x86), and ran the curl test. Same results as with the original curl.

I suggest to merge this PR, but not to upload the builds yet, because the dependencies might not be up-to-date with those for master.

@shivammathur, @nielsdos, what do you think?

@nielsdos
Copy link
Contributor

Sounds good, nghttp2 may need an update as well before building. I always updated and built nghttp2 first and then did it for curl.

@Jan-E
Copy link
Contributor

Jan-E commented Jul 25, 2024

Nghttp2 is the only dependency that I always give an update before rebuilding Curl

@cmb69
Copy link
Member Author

cmb69 commented Jul 26, 2024

Hmm, is nghttp2's API so unstable nowadays, that there are issues with the dynamic linking? Or this about new features in new minor releases which can be used by curl if available?

Anyway, @shivammathur provided winlibs/nghttp2@f7b724e, and is currently building.

@nielsdos
Copy link
Contributor

Hmm, is nghttp2's API so unstable nowadays, that there are issues with the dynamic linking? Or this about new features in new minor releases which can be used by curl if available?

The latter, making sure it's aware of the potentially new features.

@cmb69
Copy link
Member Author

cmb69 commented Jul 29, 2024

It just has been announced that cURL 8.9.1 ("a patch release to fix a few regressions in the recent release") will be released on Wednesday, so we probably want to wait for that anyway.

@Jan-E
Copy link
Contributor

Jan-E commented Jul 29, 2024

That probably is a regression when building curl on iOS: curl/curl#14269
But it does not harm to wait 2 more days.

Edit. And a fix for the cmdline tool: curl/curl#14304

@cmb69
Copy link
Member Author

cmb69 commented Jul 31, 2024

Good news: https://curl.se/docs/CVE-2024-7264.html does not affect the OpenSSL backend, so our builds are not affected.

The question is: do we want to merge this PR, or just skip 8.9.0, and go with 8.9.1 right away?

@nielsdos
Copy link
Contributor

The question is: do we want to merge this PR, or just skip 8.9.0, and go with 8.9.1 right away?

I would skip 8.9.0 and go to 8.9.1: vulnerability scanners are stupid and will just check the version number and claim that the CVE applies (even if it doesn't affect our configuration).

@cmb69
Copy link
Member Author

cmb69 commented Jul 31, 2024

Okay, fine for me. I'll provide a PR for 8.9.1 within the next days (probably tomorrow).

@cmb69 cmb69 closed this Jul 31, 2024
@cmb69 cmb69 mentioned this pull request Aug 1, 2024
@cmb69 cmb69 deleted the cmb/8.9.0 branch August 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants