Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for elixir heex files #220

Closed
wants to merge 1 commit into from

Conversation

dan-cooke
Copy link

@PriceHiller
Copy link
Collaborator

Thanks for the PR @dan-cooke!

Did you ever get a chance to test this for elixir heex files?

@dan-cooke
Copy link
Author

@PriceHiller so I’ve tested briefly , it works for normal HTML tags but anything with dots in them - it does not complete

Eg

<.button will not work

I am not sure how best to handle this with the plugin, any ideas?

@PriceHiller
Copy link
Collaborator

Wow, that was a fast response.

So the unfortunate bit is that we register to a keybind in insert mode triggered by tag openers and closers.

See

vim.keymap.set("i", ">", function()

and

vim.keymap.set("i", "/", function()

In effect, that means we'd have to create a keybind that maps to . and then looks one character back for a < to trigger an autoclose. That may lead to other issues in how we manage the tags, would have to try to know for sure.

I'm not familiar with heex, does it not create a tag on a closing > or a /?

I'm good with merging this if you're happy with the functionality added by the alias.

@PriceHiller
Copy link
Collaborator

Closed by #223, thanks for the attempt 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants