Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Application object instead of the setup #58

Merged

Conversation

midays
Copy link
Collaborator

@midays midays commented Feb 1, 2024

When creating a configuration, instead of passing both setup fixtures for vscode and intellij, it's changed to only create an object of the application, due to 2 reasons:

  1. The setup is already called when starting the test
  2. This will prevent calling un wanted setup. e.g. when executing for vscode it will only call for vscode.

@midays midays added RFR Ready for review infra PR related to infra changes vscode and removed vscode labels Feb 1, 2024
@sshveta sshveta merged commit e6e51ac into main Feb 5, 2024
2 checks passed
@midays midays deleted the vscode_fix_Application_calling_in_configuration_fixture branch February 7, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra PR related to infra changes RFR Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants