This repository was archived by the owner on Apr 11, 2023. It is now read-only.
Integer division results in no adaptation#10
Open
cdcapano wants to merge 1 commit intowillvousden:mainfrom
Open
Integer division results in no adaptation#10cdcapano wants to merge 1 commit intowillvousden:mainfrom
cdcapano wants to merge 1 commit intowillvousden:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decay and kappa are calculated in
_get_ladder_adjustmentin (lines 180 and 181 inensemble.py), a division with integers is performed. Sincedecayis always less than 1, this results in decay and kappa always being zero if you're not using python 3. The result is the betas are never changed.This fixes that by importing division from future in
ensemble.py.