chore: impact only calc the referenced

williamfzc · Aug 14, 2023 · 5268463 · 5268463
1 parent 0dcf086
commit 5268463
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 21 deletions.
diff --git a/graph/file/api_stat.go b/graph/file/api_stat.go
@@ -18,9 +18,8 @@ func (fg *Graph) Stat(f *Vertex) *object.ImpactUnit {
 	impactUnit.FileName = f.Path
 	impactUnit.UnitName = f.Id()
 
-	impactUnit.ImpactCount = len(referencedIds) + len(referenceIds)
-	impactUnit.TransImpactCount = len(transitiveReferenceIds) + len(transitiveReferencedIds)
-
+	impactUnit.ImpactCount = len(referencedIds)
+	impactUnit.TransImpactCount = len(transitiveReferencedIds)
 	impactUnit.ImpactEntries = len(entries)
 
 	// details
@@ -70,10 +69,9 @@ func (fg *Graph) GlobalStat(points []*Vertex) *object.StatGlobal {
 			eachId := sg.UnitMapping[eachReferenced]
 			directImpactMap[eachId] = struct{}{}
 		}
-		for _, eachReference := range each.ReferenceIds {
-			eachId := sg.UnitMapping[eachReference]
-			directImpactMap[eachId] = struct{}{}
-		}
+		// and itself
+		itselfId := sg.UnitMapping[each.Self.Id()]
+		directImpactMap[itselfId] = struct{}{}
 	}
 	directImpactList := make([]int, 0, len(directImpactMap))
 	for each := range directImpactMap {
@@ -88,10 +86,9 @@ func (fg *Graph) GlobalStat(points []*Vertex) *object.StatGlobal {
 			eachId := sg.UnitMapping[eachReferenced]
 			indirectImpactMap[eachId] = struct{}{}
 		}
-		for _, eachReference := range each.TransitiveReferenceIds {
-			eachId := sg.UnitMapping[eachReference]
-			indirectImpactMap[eachId] = struct{}{}
-		}
+		// and itself
+		itselfId := sg.UnitMapping[each.Self.Id()]
+		indirectImpactMap[itselfId] = struct{}{}
 	}
 	indirectImpactList := make([]int, 0, len(indirectImpactMap))
 	for each := range indirectImpactMap {

diff --git a/graph/function/api_stat.go b/graph/function/api_stat.go
@@ -15,8 +15,8 @@ func (fg *Graph) Stat(f *Vertex) *object.ImpactUnit {
 	impactUnit.FileName = f.Path
 	impactUnit.UnitName = f.Id()
 
-	impactUnit.ImpactCount = len(referencedIds) + len(referenceIds)
-	impactUnit.TransImpactCount = len(transitiveReferenceIds) + len(transitiveReferencedIds)
+	impactUnit.ImpactCount = len(referencedIds)
+	impactUnit.TransImpactCount = len(transitiveReferencedIds)
 	impactUnit.ImpactEntries = len(entries)
 
 	// details
@@ -66,10 +66,6 @@ func (fg *Graph) GlobalStat(points []*Vertex) *object.StatGlobal {
 			eachId := sg.UnitMapping[eachReferenced]
 			directImpactMap[eachId] = struct{}{}
 		}
-		for _, eachReference := range each.ReferenceIds {
-			eachId := sg.UnitMapping[eachReference]
-			directImpactMap[eachId] = struct{}{}
-		}
 		// and itself
 		itselfId := sg.UnitMapping[each.Self.Id()]
 		directImpactMap[itselfId] = struct{}{}
@@ -87,10 +83,9 @@ func (fg *Graph) GlobalStat(points []*Vertex) *object.StatGlobal {
 			eachId := sg.UnitMapping[eachReferenced]
 			indirectImpactMap[eachId] = struct{}{}
 		}
-		for _, eachReference := range each.TransitiveReferenceIds {
-			eachId := sg.UnitMapping[eachReference]
-			indirectImpactMap[eachId] = struct{}{}
-		}
+		// and itself
+		itselfId := sg.UnitMapping[each.Self.Id()]
+		indirectImpactMap[itselfId] = struct{}{}
 	}
 	indirectImpactList := make([]int, 0, len(indirectImpactMap))
 	for each := range indirectImpactMap {